Skip to content

Commit da92e5d

Browse files
committed
Remove some ipproto constants
1 parent ba7918a commit da92e5d

File tree

2 files changed

+15
-51
lines changed

2 files changed

+15
-51
lines changed

shared-bindings/socketpool/SocketPool.c

Lines changed: 9 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -81,32 +81,12 @@ MP_DEFINE_EXCEPTION(gaierror, OSError)
8181
//|
8282
//| TCP_NODELAY: int
8383
//|
84-
//| IPPROTO_TCP: int
8584
//| IPPROTO_IP: int
86-
//| IPPROTO_AH: int
87-
//| IPPROTO_DSTOPTS: int
88-
//| IPPROTO_EGP: int
89-
//| IPPROTO_ESP: int
90-
//| IPPROTO_FRAGMENT: int
91-
//| IPPROTO_GRE: int
92-
//| IPPROTO_HOPOPTS: int
9385
//| IPPROTO_ICMP: int
94-
//| IPPROTO_ICMPV6: int
95-
//| IPPROTO_IDP: int
96-
//| IPPROTO_IGMP: int
97-
//| IPPROTO_IPIP: int
86+
//| IPPROTO_TCP: int
87+
//| IPPROTO_UDP: int
9888
//| IPPROTO_IPV6: int
99-
//| IPPROTO_MPTCP: int
100-
//| IPPROTO_NONE: int
101-
//| IPPROTO_PIM: int
102-
//| IPPROTO_PUP: int
10389
//| IPPROTO_RAW: int
104-
//| IPPROTO_ROUTING: int
105-
//| IPPROTO_RSVP: int
106-
//| IPPROTO_SCTP: int
107-
//| IPPROTO_TP: int
108-
//| IPPROTO_UDP: int
109-
//| IPPROTO_UDPLITE: int
11090
//|
11191
//| IP_MULTICAST_TTL: int
11292
//|
@@ -117,7 +97,7 @@ MP_DEFINE_EXCEPTION(gaierror, OSError)
11797
//|
11898
//| :param ~int family: AF_INET or AF_INET6
11999
//| :param ~int type: SOCK_STREAM, SOCK_DGRAM or SOCK_RAW
120-
//| :param ~int proto: IPPROTO_TCP, IPPROTO_IP or any other IPPROTO_ constant. Only works with SOCK_RAW
100+
//| :param ~int proto: IPPROTO_IP, IPPROTO_ICMP, IPPROTO_TCP, IPPROTO_UDP, IPPROTO_IPV6or IPPROTO_RAW. Only works with SOCK_RAW
121101
//|
122102
//| The ``fileno`` argument available in ``socket.socket()``
123103
//| in CPython is not supported.
@@ -218,8 +198,12 @@ STATIC const mp_rom_map_elem_t socketpool_socketpool_locals_dict_table[] = {
218198

219199
{ MP_ROM_QSTR(MP_QSTR_TCP_NODELAY), MP_ROM_INT(SOCKETPOOL_TCP_NODELAY) },
220200

221-
{ MP_ROM_QSTR(MP_QSTR_IPPROTO_TCP), MP_ROM_INT(SOCKETPOOL_IPPROTO_TCP) },
222-
{ MP_ROM_QSTR(MP_QSTR_IPPROTO_IP), MP_ROM_INT(SOCKETPOOL_IPPROTO_IP) },
201+
{ MP_ROM_QSTR(MP_QSTR_IPPROTO_IP), MP_ROM_INT(MOD_NETWORK_IPPROTO_IP) },
202+
{ MP_ROM_QSTR(MP_QSTR_IPPROTO_ICMP), MP_ROM_INT(MOD_NETWORK_IPPROTO_ICMP) },
203+
{ MP_ROM_QSTR(MP_QSTR_IPPROTO_TCP), MP_ROM_INT(MOD_NETWORK_IPPROTO_TCP) },
204+
{ MP_ROM_QSTR(MP_QSTR_IPPROTO_UDP), MP_ROM_INT(MOD_NETWORK_IPPROTO_UDP) },
205+
{ MP_ROM_QSTR(MP_QSTR_IPPROTO_IPV6), MP_ROM_INT(MOD_NETWORK_IPPROTO_IPV6) },
206+
{ MP_ROM_QSTR(MP_QSTR_IPPROTO_RAW), MP_ROM_INT(MOD_NETWORK_IPPROTO_RAW) },
223207
{ MP_ROM_QSTR(MP_QSTR_IP_MULTICAST_TTL), MP_ROM_INT(SOCKETPOOL_IP_MULTICAST_TTL) },
224208

225209
{ MP_ROM_QSTR(MP_QSTR_EAI_NONAME), MP_ROM_INT(SOCKETPOOL_EAI_NONAME) },

shared-bindings/socketpool/SocketPool.h

Lines changed: 6 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -45,32 +45,12 @@ typedef enum {
4545
} socketpool_socketpool_addressfamily_t;
4646

4747
typedef enum {
48-
SOCKETPOOL_IPPROTO_AH = 51,
49-
SOCKETPOOL_IPPROTO_DSTOPTS = 60,
50-
SOCKETPOOL_IPPROTO_EGP = 8,
51-
SOCKETPOOL_IPPROTO_ESP = 50,
52-
SOCKETPOOL_IPPROTO_FRAGMENT = 44,
53-
SOCKETPOOL_IPPROTO_GRE = 47,
54-
SOCKETPOOL_IPPROTO_HOPOPTS = 0,
55-
SOCKETPOOL_IPPROTO_ICMP = 1,
56-
SOCKETPOOL_IPPROTO_ICMPV6 = 58,
57-
SOCKETPOOL_IPPROTO_IDP = 22,
58-
SOCKETPOOL_IPPROTO_IGMP = 2,
59-
SOCKETPOOL_IPPROTO_IP = 0,
60-
SOCKETPOOL_IPPROTO_IPIP = 4,
61-
SOCKETPOOL_IPPROTO_IPV6 = 41,
62-
SOCKETPOOL_IPPROTO_MPTCP = 262,
63-
SOCKETPOOL_IPPROTO_NONE = 59,
64-
SOCKETPOOL_IPPROTO_PIM = 103,
65-
SOCKETPOOL_IPPROTO_PUP = 12,
66-
SOCKETPOOL_IPPROTO_RAW = 255,
67-
SOCKETPOOL_IPPROTO_ROUTING = 43,
68-
SOCKETPOOL_IPPROTO_RSVP = 46,
69-
SOCKETPOOL_IPPROTO_SCTP = 132,
70-
SOCKETPOOL_IPPROTO_TCP = 6,
71-
SOCKETPOOL_IPPROTO_TP = 29,
72-
SOCKETPOOL_IPPROTO_UDP = 17,
73-
SOCKETPOOL_IPPROTO_UDPLITE = 136,
48+
SOCKETPOOL_IPPROTO_IP = 0
49+
SOCKETPOOL_IPPROTO_ICMP = 1
50+
SOCKETPOOL_IPPROTO_TCP = 6
51+
SOCKETPOOL_IPPROTO_UDP = 17
52+
SOCKETPOOL_IPPROTO_IPV6 = 41
53+
SOCKETPOOL_IPPROTO_RAW = 255
7454
} socketpool_socketpool_ipproto_t;
7555

7656
typedef enum {

0 commit comments

Comments
 (0)