Skip to content

Commit fe73cfb

Browse files
authored
Merge pull request #3333 from hierophect/esp32-enable-ulab
Fix all assignments affected by inline makefile comments
2 parents 58d5f99 + 553ac57 commit fe73cfb

File tree

6 files changed

+73
-19
lines changed

6 files changed

+73
-19
lines changed

docs/porting.rst

Lines changed: 30 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,15 @@ as a natural "TODO" list. An example minimal build list is shown below:
5151
.. code-block:: makefile
5252
5353
# These modules are implemented in ports/<port>/common-hal:
54-
CIRCUITPY_MICROCONTROLLER = 0 # Typically the first module to create
55-
CIRCUITPY_DIGITALIO = 0 # Typically the second module to create
54+
55+
# Typically the first module to create
56+
CIRCUITPY_MICROCONTROLLER = 0
57+
# Typically the second module to create
58+
CIRCUITPY_DIGITALIO = 0
59+
# Other modules:
5660
CIRCUITPY_ANALOGIO = 0
5761
CIRCUITPY_BUSIO = 0
62+
CIRCUITPY_COUNTIO = 0
5863
CIRCUITPY_NEOPIXEL_WRITE = 0
5964
CIRCUITPY_PULSEIO = 0
6065
CIRCUITPY_OS = 0
@@ -63,22 +68,34 @@ as a natural "TODO" list. An example minimal build list is shown below:
6368
CIRCUITPY_AUDIOIO = 0
6469
CIRCUITPY_ROTARYIO = 0
6570
CIRCUITPY_RTC = 0
71+
CIRCUITPY_SDCARDIO = 0
72+
CIRCUITPY_FRAMEBUFFERIO = 0
6673
CIRCUITPY_FREQUENCYIO = 0
6774
CIRCUITPY_I2CPERIPHERAL = 0
68-
CIRCUITPY_DISPLAYIO = 0 # Requires SPI, PulseIO (stub ok)
75+
# Requires SPI, PulseIO (stub ok):
76+
CIRCUITPY_DISPLAYIO = 0
6977
7078
# These modules are implemented in shared-module/ - they can be included in
7179
# any port once their prerequisites in common-hal are complete.
72-
CIRCUITPY_BITBANGIO = 0 # Requires DigitalIO
73-
CIRCUITPY_GAMEPAD = 0 # Requires DigitalIO
74-
CIRCUITPY_PIXELBUF = 0 # Requires neopixel_write or SPI (dotstar)
75-
CIRCUITPY_RANDOM = 0 # Requires OS
76-
CIRCUITPY_STORAGE = 0 # Requires OS, filesystem
77-
CIRCUITPY_TOUCHIO = 0 # Requires Microcontroller
78-
CIRCUITPY_USB_HID = 0 # Requires USB
79-
CIRCUITPY_USB_MIDI = 0 # Requires USB
80-
CIRCUITPY_REQUIRE_I2C_PULLUPS = 0 # Does nothing without I2C
81-
CIRCUITPY_ULAB = 0 # No requirements, but takes extra flash
80+
# Requires DigitalIO:
81+
CIRCUITPY_BITBANGIO = 0
82+
# Requires DigitalIO
83+
CIRCUITPY_GAMEPAD = 0
84+
# Requires neopixel_write or SPI (dotstar)
85+
CIRCUITPY_PIXELBUF = 0
86+
# Requires OS
87+
CIRCUITPY_RANDOM = 0
88+
# Requires OS, filesystem
89+
CIRCUITPY_STORAGE = 0
90+
# Requires Microcontroller
91+
CIRCUITPY_TOUCHIO = 0
92+
# Requires USB
93+
CIRCUITPY_USB_HID = 0
94+
CIRCUITPY_USB_MIDI = 0
95+
# Does nothing without I2C
96+
CIRCUITPY_REQUIRE_I2C_PULLUPS = 0
97+
# No requirements, but takes extra flash
98+
CIRCUITPY_ULAB = 0
8299
83100
Step 2: Init
84101
--------------

ports/esp32s2/mpconfigport.mk

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,11 @@ CIRCUITPY_COUNTIO = 0
2525

2626
# These modules are implemented in shared-module/ - they can be included in
2727
# any port once their prerequisites in common-hal are complete.
28-
CIRCUITPY_RANDOM = 0 # Requires OS
29-
CIRCUITPY_USB_MIDI = 0 # Requires USB
30-
CIRCUITPY_ULAB = 1 # No requirements, but takes extra flash
28+
# Requires OS
29+
CIRCUITPY_RANDOM = 0
30+
# Requires USB
31+
CIRCUITPY_USB_MIDI = 0
32+
# Too large for the partition table!
33+
CIRCUITPY_ULAB = 0
3134

3235
CIRCUITPY_MODULE ?= none

ports/stm/boards/espruino_pico/mpconfigboard.mk

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@ MCU_VARIANT = STM32F401xE
1010
MCU_PACKAGE = UFQFPN48
1111

1212
LD_COMMON = boards/common_default.ld
13-
LD_FILE = boards/STM32F401xd_fs.ld # use for internal flash
13+
# use for internal flash
14+
LD_FILE = boards/STM32F401xd_fs.ld
1415

1516
# Disable ulab as we're nearly out of space on this board due to
1617
# INTERNAL_FLASH_FILESYSTEM. It can probably be reenabled if we enable

ports/stm/boards/feather_stm32f405_express/mpconfigboard.mk

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,6 @@ MCU_PACKAGE = LQFP64
1313

1414
LD_COMMON = boards/common_default.ld
1515
LD_DEFAULT = boards/STM32F405_default.ld
16-
LD_BOOT = boards/STM32F405_boot.ld # UF2 boot option
16+
# UF2 boot option
17+
LD_BOOT = boards/STM32F405_boot.ld
1718
UF2_OFFSET = 0x8010000

ports/stm/boards/meowbit_v121/mpconfigboard.mk

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,5 @@ OPTIMIZATION_FLAGS = -Os
1818

1919
LD_COMMON = boards/common_default.ld
2020
LD_FILE = boards/STM32F401xe_boot.ld
21-
# LD_FILE = boards/STM32F401xe_fs.ld # use for internal flash
21+
# use for internal flash
22+
# LD_FILE = boards/STM32F401xe_fs.ld

tools/mpconfig_category_reader.py

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
filepath = '../py/circuitpy_mpconfig.mk'
2+
with open(filepath) as fp:
3+
line = fp.readline()
4+
cnt = 1
5+
fullbuild = []
6+
defon = []
7+
defoff = []
8+
while line:
9+
wordlist = line.split()
10+
if wordlist:
11+
if wordlist[-1] == "$(CIRCUITPY_FULL_BUILD)":
12+
fullbuild.append(wordlist[0])
13+
elif wordlist[-1] == "0":
14+
defoff.append(wordlist[0])
15+
elif wordlist[-1] == "1":
16+
defon.append(wordlist[0])
17+
line = fp.readline()
18+
cnt += 1
19+
20+
print(str(cnt) + " Lines Read\n")
21+
print("\nFULL BUILDS ------------------------")
22+
for string in fullbuild:
23+
print(string)
24+
25+
print("\nON BUILDS ------------------------")
26+
for string in defon:
27+
print(string)
28+
29+
print("\nOFF BUILDS ------------------------")
30+
for string in defoff:
31+
print(string)

0 commit comments

Comments
 (0)