A few fixes for nRF52840 feather QSPI and neopixel #1354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
neopixel works! |
ladyada
approved these changes
Nov 23, 2018
| @@ -48,7 +48,6 @@ STATIC uint32_t claimed_pins[GPIO_COUNT]; | |||
| STATIC uint32_t never_reset_pins[GPIO_COUNT]; | |||
|
|
|||
| void reset_all_pins(void) { | |||
| return; | |||
|
Looks good to me, but |
|
@dhalbert Nope, I'm going to look at it when I get my prototype. |
|
Merged anyway - I read Slack convo. |
jepler
pushed a commit
to jepler/circuitpython
that referenced
this pull request
Aug 27, 2021
See related adafruit#1354, adafruit#2906, adafruit#3436. Signed-off-by: Damien George <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.