Skip to content

report status in .travis.yml correctly #1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2019

Conversation

dhalbert
Copy link
Collaborator

Doing some command ; echo $? > status hid non-zero status from travis. Save the status and then use exit to simulate the command failure.

First push has a deliberate error to test this.

@dhalbert dhalbert force-pushed the fix-broken-build-check branch from 1a610d5 to 0854acd Compare January 18, 2019 20:13
@dhalbert dhalbert force-pushed the fix-broken-build-check branch from 0854acd to 4768d4f Compare January 18, 2019 22:24
@dhalbert dhalbert changed the title report status in .travis.yml correctly; this build deliberately fails report status in .travis.yml correctly Jan 18, 2019
@dhalbert dhalbert requested a review from tannewt January 18, 2019 22:49
@dhalbert
Copy link
Collaborator Author

dhalbert commented Jan 18, 2019

This does seem to fix "breaking the break the build" checking. There are errors in the first subjob from mp_map_t issues; I didn't attempt to fix those. The other subjobs are ok.

I originally tried:

  - some_long_command ; S=$? ; echo $S > status ; exit $S

but that causes the job to exit immediately due to the exit. You have to run the exit as as subshell:

  - some_long_command ; S=$? ; echo $S > status ; (exit $S)

@dhalbert
Copy link
Collaborator Author

@tannewt Or you could just cherry-pick this into your PR.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok breaking the current build. Thanks!

@tannewt tannewt merged commit d2a7cd6 into adafruit:master Jan 18, 2019
@dhalbert dhalbert deleted the fix-broken-build-check branch January 25, 2019 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants