Skip to content

adding height and width to OnDiskBitmap for #1460 #1479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2019
Merged

adding height and width to OnDiskBitmap for #1460 #1479

merged 1 commit into from
Jan 21, 2019

Conversation

siddacious
Copy link

I added height and width to OnDiskBitmap as per #1460

Press any key to enter the REPL. Use CTRL-D to reload.
Adafruit CircuitPython 4.0.0-alpha.5-168-gd2a7cd6c5-dirty on 2019-01-20; Adafruit Trellis M4 Express with samd51g19
>>> from displayio import OnDiskBitmap
>>> f = open("1x20orange.bmp", "rb")
>>> odb = OnDiskBitmap(f)
>>> odb.height
20
>>> odb.width
1
>>>

@siddacious siddacious requested a review from tannewt January 21, 2019 06:37
tannewt
tannewt approved these changes Jan 21, 2019
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo! Great job! Thank you!

@tannewt tannewt merged commit 2bcf81f into adafruit:master Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siddacious @tannewt