Skip to content

struct.pack_into incorrect buffer size check #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2019
Merged

struct.pack_into incorrect buffer size check #1480

merged 1 commit into from
Jan 21, 2019

Conversation

dhalbert
Copy link
Collaborator

Bad copy/paste introduced a bad bug into struct.pack_into(), making it require an exact-length buffer, which it does not.

@dhalbert dhalbert requested a review from tannewt January 21, 2019 16:46
tannewt
tannewt approved these changes Jan 21, 2019
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@tannewt tannewt merged commit 9e8d182 into adafruit:master Jan 21, 2019
@dhalbert dhalbert deleted the packinto-bug branch January 25, 2019 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhalbert @tannewt