Skip to content

More bleio revision #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 22, 2019
Merged

More bleio revision #1482

merged 5 commits into from
Jan 22, 2019

Conversation

dhalbert
Copy link
Collaborator

  • Put back string UUID parsing and printingfor bleio.UUID. No longer assume that there are adafruit_ble Python wrapper classes for most classes in bleio.
  • Make CharacteristicBuffer be a standard stream class, so that it mimics busio.UART, etc. However, it only provides read functionality
  • Protect the ring buffer in CharacteristicBuffer with a mutex.
  • Refactor ringbuf.h to include some operations that were added for nRF UART.
  • Fix a minor doc error in busio.UART.

This version is compatible with the latest PR's for https://github.com/adafruit/Adafruit_CircuitPython_BLE and https://github.com/adafruit/Adafruit_CircuitPython_BluefruitConnect. They must all be up to date to work together.

@dhalbert dhalbert requested a review from tannewt January 22, 2019 02:09
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Love the stream standardization.

@tannewt tannewt merged commit 736d21f into adafruit:master Jan 22, 2019
@dhalbert dhalbert deleted the bleio2 branch January 22, 2019 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants