Skip to content

tell people that esp8266 is no longer supported #1484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2019
Merged

tell people that esp8266 is no longer supported #1484

merged 1 commit into from
Jan 22, 2019

Conversation

larsks
Copy link

@larsks larsks commented Jan 22, 2019

closes #1483

dhalbert
dhalbert previously requested changes Jan 22, 2019
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just make it print the warning without deleting the rest of the content? Then merges from upstream will be easier.

@larsks
Copy link
Author

larsks commented Jan 22, 2019

Sure.

@larsks
Copy link
Author

larsks commented Jan 22, 2019

For the record, this was my first thought: https://asciinema.org/a/dy4PQaNl1PQiQt09iNrJeGbCy

tannewt
tannewt approved these changes Jan 22, 2019
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Sorry for the surprise.

@tannewt tannewt merged commit f46ec02 into adafruit:master Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

@dhalbert dhalbert dhalbert left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does not build for esp8266
3 participants
@larsks @tannewt @dhalbert