Skip to content

Fix displaying images off of SD cards. #1552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 20, 2019
Merged

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Feb 15, 2019

This also fixes writability checks so the internal filesystem is no longer writable with a storage.remount. Use the SD card for caching.

The pyportal init has been changed to speed up displaying bitmaps by aligning their access pattern with their orientation.

dhalbert
dhalbert previously approved these changes Feb 16, 2019
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't test but looks good!

@dhalbert
Copy link
Collaborator

Needs merging from upstream.

@ladyada
Copy link
Member

ladyada commented Feb 19, 2019

fully tested, including making an SD card slideshow - can be merged when ya like

@tannewt
Copy link
Member Author

tannewt commented Feb 19, 2019

@dhalbert Please take another look. I rebased and Travis is happy.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dhalbert dhalbert merged commit 0dc2600 into adafruit:master Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants