Skip to content

Make displayio.Palette support more than 255 colors #1676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2019
Merged

Make displayio.Palette support more than 255 colors #1676

merged 1 commit into from
Mar 20, 2019

Conversation

deshipu
Copy link

@deshipu deshipu commented Mar 20, 2019

Fix #1671

tannewt
tannewt approved these changes Mar 20, 2019
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! Note that Bitmap doesn't support values > 255 I believe.

@tannewt tannewt merged commit 9f3ca66 into adafruit:master Mar 20, 2019
@deshipu
Copy link
Author

deshipu commented Mar 20, 2019

Not yet, anyways, but at least it now raises an exception about it.

@tannewt
Copy link
Member

tannewt commented Mar 20, 2019

Yup! Totally. Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deshipu @tannewt