Skip to content

Revert "Circuitpython nickzoic 1046 nrf rtc" #1726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2019

Conversation

dhalbert
Copy link
Collaborator

Reverts #1534.

This breaks BLE:

>>> from adafruit_ble.uart import UARTServer
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "adafruit_ble/uart.py", line 34, in <module>
  File "adafruit_ble/uart.py", line 56, in UARTServer
OSError: Failed to change softdevice state

We'll need to check this out more thoroughly. Reverting so we can release a beta.6 with other fixes.

@dhalbert dhalbert requested a review from tannewt March 29, 2019 20:42
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! We can sort out the issue after Beta 6

@tannewt tannewt merged commit 5ad69b2 into master Mar 29, 2019
@tannewt
Copy link
Member

tannewt commented Mar 29, 2019

Merged because one build was ok. The LWIP git server isn't happy.

@dhalbert dhalbert deleted the revert-1534-circuitpython-nickzoic-1046-nrf-rtc branch March 30, 2019 02:21
@nickzoic
Copy link

nickzoic commented Apr 2, 2019

Ah, thanks Dan, I missed the cross-reference to this one! I'll make a new pull request ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants