Skip to content

ROTARYIO_MODULE typo; EIC interrupt handler refactor #1745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 5, 2019

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Apr 4, 2019

This is dependent on adafruit/samd-peripherals#21, so I'll make this a final PR once that's accepted. This draft is being submitted so you can see the changes on the CPy side.

@dhalbert dhalbert marked this pull request as ready for review April 4, 2019 20:36
@dhalbert dhalbert added this to the 4.0.0 - Bluetooth milestone Apr 4, 2019
@dhalbert
Copy link
Collaborator Author

dhalbert commented Apr 4, 2019

Fixes #1656.

@dhalbert
Copy link
Collaborator Author

dhalbert commented Apr 5, 2019

@deshipu I turned off rotaryio on pewpew10 to make its de_DE build fit. rotaryio was already off by accident; this just turns it off deliberately for that board. If you think you want it, we can try decreasing CFLAGS_INLINE_LIMIT. The German translation could probably also be made skinnier.

@dhalbert
Copy link
Collaborator Author

dhalbert commented Apr 5, 2019

@tannewt This is ready to merge. No one else is around; I can wait for you.

@dhalbert dhalbert merged commit b5bc8b3 into adafruit:master Apr 5, 2019
@dhalbert dhalbert deleted the rotaryio-typo-eic-refactor branch April 5, 2019 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants