Skip to content

update tinyusb to fix disconnect/suspend issue with #1681 #1748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 5, 2019

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Apr 4, 2019

Also check for disconnect while writing a string, in case a disconnect happens during writing.

@dhalbert dhalbert requested a review from hathach April 4, 2019 22:55
@dhalbert dhalbert marked this pull request as ready for review April 5, 2019 02:48
@dhalbert dhalbert requested a review from tannewt April 5, 2019 02:48
@dhalbert
Copy link
Collaborator Author

dhalbert commented Apr 5, 2019

Fixes #1681.

hathach
hathach previously approved these changes Apr 5, 2019
Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good to merge

@dhalbert
Copy link
Collaborator Author

dhalbert commented Apr 5, 2019

Changing from draft to ready for review didn't trigger a build :(

@dhalbert dhalbert closed this Apr 5, 2019
@dhalbert dhalbert reopened this Apr 5, 2019
@dhalbert
Copy link
Collaborator Author

dhalbert commented Apr 5, 2019

Was able to trigger a build by closing and reopening.

@dhalbert dhalbert added this to the 4.0.0 - Bluetooth milestone Apr 5, 2019
@hathach
Copy link
Member

hathach commented Apr 5, 2019

@dhalbert you should also merge this PR for usb descriptor adafruit/usb_descriptor#7

and bump it up in this pr as well

@dhalbert
Copy link
Collaborator Author

dhalbert commented Apr 5, 2019

@dhalbert you should also merge this PR for usb descriptor adafruit/usb_descriptor#7

and bump it up in this pr as well

Done! I didn't see that.

@dhalbert
Copy link
Collaborator Author

dhalbert commented Apr 5, 2019

@tannewt or @hathach This is ready for approval and merging (finally).

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@tannewt tannewt merged commit b9e3781 into adafruit:master Apr 5, 2019
@dhalbert dhalbert deleted the usb-disconnect branch April 5, 2019 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants