Skip to content

Allow parameter data to be treated as commands for the ssd1331 #1751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 5, 2019
Merged

Allow parameter data to be treated as commands for the ssd1331 #1751

merged 5 commits into from
Apr 5, 2019

Conversation

makermelissa
Copy link
Collaborator

This fixes #1750

@makermelissa makermelissa requested a review from tannewt April 5, 2019 06:21
@makermelissa makermelissa mentioned this pull request Apr 5, 2019
Merged
tannewt
tannewt reviewed Apr 5, 2019
View reviewed changes
tannewt
tannewt previously approved these changes Apr 5, 2019
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you.

@makermelissa
Copy link
Collaborator Author

Looks like the extra bytes are causing the same issue with #1733 to pop up again and travis is failing. What would be the best strategy to fix this?

@dhalbert
Copy link
Collaborator

dhalbert commented Apr 5, 2019

In ports/atmel-samd/boards/hallowing_m0_express/mpconfigboard.mk, lower CFLAGS_INLINE_LIMIT to 50, and/or turn off some features (e.g., CIRCUITPY_SAMD = 0)

@dhalbert
Copy link
Collaborator

dhalbert commented Apr 5, 2019

Do a local test with the pl build to vet the change.

@makermelissa
Copy link
Collaborator Author

Thanks Dan. Adjusted the limit and local PL build succeeded. Trying again.

@makermelissa makermelissa modified the milestones: 4.x, 4.0.0 - Bluetooth Apr 5, 2019
dhalbert
dhalbert approved these changes Apr 5, 2019
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on @tannewt 's previous approval. Excellent!

@dhalbert dhalbert merged commit df058c9 into adafruit:master Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

@tannewt tannewt tannewt left review comments

Assignees
No one assigned
Labels
displayio enhancement
Projects
None yet
Milestone
4.0.0 - Bluetooth
Development

Successfully merging this pull request may close these issues.

Allow displayio to treat all SPI parameters as commands
3 participants
@makermelissa @dhalbert @tannewt