Skip to content

Enable _stage module and freeze stage library on the PyBadge #1790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2019
Merged

Enable _stage module and freeze stage library on the PyBadge #1790

merged 1 commit into from
Apr 15, 2019

Conversation

deshipu
Copy link

@deshipu deshipu commented Apr 13, 2019

This requires #1778

Add a variant of the pybadge board definition, that has the _stage module enabled, and includes frozen stage and ugame modules, for running µGame games.

Since the stage library doesn't allow rotating the screen in software, and uses RGB pixels (and not BGR), I had to modify the MADCTL register in the display initialization, in addition to adding all the required modules.

@tannewt
Copy link
Member

tannewt commented Apr 15, 2019

I'd rather not introduce a build variant. Why don't we just enable _stage? We have enough memory for stage and ugame. For MADCTL you can release_displays and reinit it yourself.

@deshipu
Copy link
Author

deshipu commented Apr 15, 2019

Sure, we can do that.

@deshipu deshipu changed the title Add pybadge_ugame board variant Enable _stage module and freeze stage library on the PyBadge Apr 15, 2019
@deshipu
Copy link
Author

deshipu commented Apr 15, 2019

I cleaned up this pull request, but it still requires #1778 for the python code to work.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thank you!

@tannewt tannewt merged commit 22889ca into adafruit:master Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants