Skip to content

Add documentation for Palette shared binding #1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 14, 2019

Conversation

matt-land
Copy link

Add documentation for the palette subscript operator and how to use it.

Add documentation for the palette subscript operator and how to use it.
Copy link
Member

@ladyada ladyada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think you can also set it to None if you want transparant

ladyada
ladyada previously approved these changes May 10, 2019
@ladyada
Copy link
Member

ladyada commented May 10, 2019

lgtm but ill let @tannewt do another check in case i missed something :)

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None doesn't currently mean transparent. It's not a bad idea though.

For now I think it will throw an error so please update the docs for as it is now.

Remove None, add in byte and bytearray examples
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit c6c6171 into adafruit:master May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants