Include display objects in gc #1928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
reviewed
Jun 6, 2019
|
@ATMakersBill did test this and he no longers sees the crashes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Groupobject inDisplaywas not being marked during gc. Because thedisplayobjects are not on the heap, they can't be added to the root pointer list. So gc them explicitly.Also:
gc_collect_ptr()routine to gc a single pointer, for convenience.#ifdefs that should have been#ifs.#ifs innrfport.#ifguard inreset_displays().SAMD21platform setting from some doc.In the long run we could use a more general mechanism, or at least perhaps factor this code into
supervisorto hide the details frommain.c. (As discussed with @tannewt.)