Skip to content

Add baudrate to FourWire and shorten delay. #1953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 18, 2019
Merged

Add baudrate to FourWire and shorten delay. #1953

merged 2 commits into from
Jun 18, 2019

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Jun 18, 2019

Speeds up FourWire and makes it easy to set the baudrate of it.

@tannewt tannewt added this to the 4.1.0 milestone Jun 18, 2019
@tannewt tannewt requested review from makermelissa and dhalbert June 18, 2019 01:08
ladyada
ladyada approved these changes Jun 18, 2019
View reviewed changes
Copy link
Member

@ladyada ladyada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested that UF2 you gave me, and its soooo fast!

dhalbert
dhalbert approved these changes Jun 18, 2019
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Note that on nRF52840 the max baudrate will be 8MHz. SPIM3, which would support 32MHz, is not available due to hardware bugs.

@tannewt
Copy link
Member Author

tannewt commented Jun 18, 2019

@dhalbert That's fine. I commented it as the maximum speed of the bus (display + wires) to imply that it may be slower.

@tannewt tannewt merged commit e6ded8d into adafruit:master Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladyada ladyada ladyada approved these changes

@dhalbert dhalbert dhalbert approved these changes

@makermelissa makermelissa Awaiting requested review from makermelissa

Assignees
No one assigned
Labels
bug displayio enhancement
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tannewt @ladyada @dhalbert