Skip to content

Support __bytes__ #2220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 15, 2019
Merged

Support __bytes__ #2220

merged 2 commits into from
Oct 15, 2019

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Oct 14, 2019

Fixes #1763

@tannewt tannewt requested a review from dhalbert October 14, 2019 23:06
ladyada
ladyada reviewed Oct 14, 2019
View reviewed changes
Copy link
Member

@ladyada ladyada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat!

dhalbert
dhalbert approved these changes Oct 15, 2019
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, looks good, tried the same thing in CPython to verify.

@dhalbert dhalbert merged commit 9de155a into adafruit:master Oct 15, 2019
@dhalbert dhalbert mentioned this pull request Jun 27, 2021
Closed
@amotl amotl mentioned this pull request Sep 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladyada ladyada ladyada left review comments

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement bytes(object)
3 participants
@tannewt @ladyada @dhalbert