Skip to content

Switch to the new release event type filter #2222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2019
Merged

Switch to the new release event type filter #2222

merged 1 commit into from
Oct 15, 2019

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Oct 15, 2019

Fixes #2201

@tannewt tannewt added this to the Long term milestone Oct 15, 2019
dhalbert
dhalbert previously approved these changes Oct 15, 2019
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tannewt Looks good! I have to go out, so assuming it works, feel free to merge.

@dhalbert
Copy link
Collaborator

@tannewt This only did a "test" check, it didn't do a complete build of all the boards.

@dhalbert dhalbert self-requested a review October 15, 2019 18:40
@dhalbert dhalbert dismissed their stale review October 15, 2019 18:40

checks failed

dhalbert
dhalbert approved these changes Oct 15, 2019
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, apparently the checks were just considerably delayed for some reason.

@dhalbert dhalbert merged commit 64c1484 into adafruit:master Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
enhancement tooling
Projects
None yet
Milestone
Long term
Development

Successfully merging this pull request may close these issues.

Replace release type hack for GitHub Actions
2 participants
@tannewt @dhalbert