Skip to content

Enable float instructions support for asm_thumb #2276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

gpshead
Copy link

@gpshead gpshead commented Nov 8, 2019

Hot on the heels of #2271, enable floating point instruction support when @micropython.asm_thumb is enabled.

This blindly assumes CIRCUITPY_ENABLE_MPY_NATIVE is only likely to be specified on boards with more ram which to me implies m4 which implies hardware floating point.

If native is desired on lesser boards (will it reasonably fit there?), we'd need to plumb through a conditional about that to && into the define. I didn't see an obvious existing define, just a soft-float compiler flag, so I'm not trying to plumb that in pre-emptively.

@gpshead
Copy link
Author

gpshead commented Nov 8, 2019

LOL... examining things, this doesn't look needed anymore.

py/mpconfig.h now auto-defines this one. (ISTR that wasn't the case a year or two back).

closing. :)

@gpshead gpshead closed this Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant