-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Use BluetoothError in _bleio #2311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This better differentiates errors than using OSError everywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very nice cleanup.
One thing to check: do these str/repr/print properly as _bleio.RoleError
, etc? These appear to be the first native-module-namespace exceptions we have in the code base.
Ok @dhalbert please take another look. Printing now includes the module by overriding the print method.
|
I may have asked for too much. Here's CPython and current CircuitPython:
CPython:
CircuitPython 5.0.0-beta.0:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The print
change now matches CPython, but the repr()
change does not. Could you undo that? That's the last thing. Thanks!
See
#2311 (comment)
Easy enough. Please take another look.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
This better differentiates errors than using OSError everywhere.