Skip to content

Check connection validity after service discovery. #2362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2019
Merged

Check connection validity after service discovery. #2362

merged 1 commit into from
Dec 7, 2019

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Dec 7, 2019

Instead of HardFaulting it will now raise a ConnectionError when a disconnect happens while discovering services.

Fixes #2347

@tannewt tannewt added this to the 5.0.0 milestone Dec 7, 2019
dhalbert
dhalbert approved these changes Dec 7, 2019
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Things can go wrong all the time when talking to to other computers :)

@dhalbert dhalbert merged commit fe05be8 into adafruit:master Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees

@dhalbert dhalbert

Labels
bug crash nordic
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

Bluefruit code crashing to Hardfault_Handler
2 participants
@tannewt @dhalbert