Fix flash write error handling; clean up safe mode message printing #2381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
force-pushed
the
nvm-write-safe-mode-cleanup
branch
from
387127b to
7889b99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nrf_nvm_safe_flash_page_write()was throwing Python exceptions, though it could be called from a non-Python context. Have it return success/failure and have the callers handle the error.FLASH_WRITE_FAILto possible reasons to go into safe mode.FLASH_WRITE_FAIL, redidprint_safe_mode_message()so it uses case statements and reduces the length of the messages.This is a clean-up follow-on to #2376.