displayio: make 'rotation' property settable #2390
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discord's andyleer and I both recently noticed that it is not possible to set the rotation property of a
display. This is inconvenient if you want to change the rotation, as you have to copy the initialization from core C code into Python. Since e.g., the Pynt's blurb on adafruit.com says
we should probably make it easy.
This lightly tested change does that, including resizing the terminal when you do. If you've got your own Groups displaying, you may need to reinitialize them. (I only tested it with terminal or with resetting the displayed group immediately)
(I also want to use this as a workaround for #2386 in JEplayer, I'll just flip the display orientation to the one that is faster)