Skip to content

Increase CPX stack size slightly #2393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2019
Merged

Increase CPX stack size slightly #2393

merged 1 commit into from
Dec 17, 2019

Conversation

dhalbert
Copy link
Collaborator

The restructured CP library with code in __init__.py and a subclass structure overflows the stack on import. Increase CPX stack size slightly (4096 -> 4504).

This change may also be needed on 4.x.

@dhalbert dhalbert requested review from tannewt and kattni December 16, 2019 22:26
jepler added a commit to jepler/circuitpython that referenced this pull request Dec 17, 2019
@jepler
Increase stack size (Back-port adafruit#2393 to 4.x)
aaea755
@jepler jepler mentioned this pull request Dec 17, 2019
Closed
kattni
kattni approved these changes Dec 17, 2019
View reviewed changes
Copy link

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New library works successfully with this change. Tested every available example in the Circuit Playground repo. Thanks for making this change!

@kattni kattni mentioned this pull request Dec 17, 2019
Merged
tannewt
tannewt approved these changes Dec 17, 2019
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@tannewt tannewt merged commit e9cb47f into adafruit:master Dec 17, 2019
dhalbert pushed a commit to dhalbert/circuitpython that referenced this pull request Dec 18, 2019
@jepler @dhalbert
Increase stack size (Back-port adafruit#2393 to 4.x)
241988b
@dhalbert dhalbert mentioned this pull request Dec 20, 2019
Closed
@dhalbert dhalbert deleted the increase-cpx-stack branch February 29, 2020 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

@kattni kattni kattni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhalbert @tannewt @kattni