Skip to content

upgrade nrfx API to v2 #2395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 18, 2019
Merged

upgrade nrfx API to v2 #2395

merged 3 commits into from
Dec 18, 2019

Conversation

hathach
Copy link
Member

@hathach hathach commented Dec 17, 2019 •
edited
Loading

Follow up to adafruit/nrfx#4 , nrfx v2 API is breaking changes with new argument, api rename, function move around etc ... v2 is needed to compile with tinyusb master's tip since it is required to support latest mcu such as nrf52833 and nrf5340

List to do before merge

  • merged upgrade nrfx to v2 nrfx#4 , then bump nrfx submodule version to merged one.
  • Most of peripheral drivers are changes and need re-test (finding some py file to test now :)
    • i2c
    • neopixel
    • spi
    • uarte
    • saadc
    • pulsein
    • random generator

@hathach hathach requested review from tannewt and dhalbert December 17, 2019 15:14
@hathach hathach mentioned this pull request Dec 17, 2019
Merged
@hierophect hierophect mentioned this pull request Dec 17, 2019
Merged
4 tasks
@hathach
Copy link
Member Author

hathach commented Dec 18, 2019

all peripherals are tested

@tannewt tannewt changed the title [WIP] upgrade nrfx API to v2 upgrade nrfx API to v2 Dec 18, 2019
tannewt
tannewt approved these changes Dec 18, 2019
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

@hathach hathach merged commit 25df6e6 into adafruit:master Dec 18, 2019
@tannewt tannewt mentioned this pull request Dec 18, 2019
Closed
@jerryneedell jerryneedell mentioned this pull request Dec 21, 2019
Closed
@hathach hathach deleted the nrfx-v2 branch December 23, 2019 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

@dhalbert dhalbert Awaiting requested review from dhalbert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hathach @tannewt