Skip to content

preprocess_frozen_modules: exclude subdirs of examples, docs, tests #2398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2019

Conversation

jepler
Copy link

@jepler jepler commented Dec 17, 2019

.. this reclaims several kB on CPX, where we really need it.

.. this reclaims several kB on CPX, where we really need it.
@dhalbert
Copy link
Collaborator

Just to be clear, this is removing subdirs of the subdirs directory, e.g. examples/advanced_examples.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I should have considered this possibility earlier.

@dhalbert dhalbert merged commit 8d43848 into adafruit:4.1.x Dec 17, 2019
@kevinjwalters
Copy link

kevinjwalters commented Dec 17, 2019

"reclaims several kB on CPX" - this is referring to space in the CIRCUITPY flash storage? What's getting smaller here?

@dhalbert
Copy link
Collaborator

Yes, but, this is due to new examples in a subdir in a new version of a frozen library: the old builds did not have this space to recover.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants