Skip to content

PacketBuffer.packet_size was returning bool instead of int #2554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2020
Merged

PacketBuffer.packet_size was returning bool instead of int #2554

merged 1 commit into from
Jan 29, 2020

Conversation

dhalbert
Copy link
Collaborator

  • Fix return value for PacketBuffer.packet_size
  • Fix some documentation issues. It doesn't seem possible to use backticks in function signatures: they get included literally in the signature. If you know how to fix this let me know.

@dhalbert dhalbert requested a review from tannewt January 27, 2020 22:12
tannewt
tannewt approved these changes Jan 27, 2020
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes! I don't know how the ticks work. Feel free to merge after the CI is happy.

@tannewt tannewt merged commit 7d4f9fc into adafruit:master Jan 29, 2020
@dhalbert dhalbert deleted the packetbuffer-packet_size branch January 31, 2020 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhalbert @tannewt