Skip to content

Add support for external flash device Winbond W25Q80DV #2594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2020

Conversation

lgnashold
Copy link

Currently, we only support external flash device W25Q80DL. This adds support for the W25Q80DL. They are very similar, but they are not interoperable because of a different memory type.

See #2593

This is my first PR in this repo, so let me know if I need to make any changes!

@lgnashold lgnashold requested a review from tannewt February 6, 2020 05:57
Copy link
Member

@ladyada ladyada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ladyada
Copy link
Member

ladyada commented Feb 6, 2020

you need to change this name #define W25Q80DL if its a different chip

Currently, we only support external flash device W25Q80DL. This
adds support for the W25Q80DL.

tweak
@lgnashold lgnashold changed the title Add support for external flash device Winbond.com W25Q80DV Add support for external flash device Winbond W25Q80DV Feb 7, 2020
@lgnashold
Copy link
Author

Sorry, that was a typo (forgot to change L to V when I copy-pasted). Should be fixed now.

@lgnashold lgnashold requested a review from ladyada February 7, 2020 00:48
Copy link
Member

@ladyada ladyada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@lgnashold lgnashold removed the request for review from tannewt February 7, 2020 09:26
@tannewt tannewt merged commit 2b8f9b2 into adafruit:master Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants