Fix I2C clock divider #2659
Merged
Fix I2C clock divider #2659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturo182
approved these changes
Feb 27, 2020
|
@mubes Did you check the frequencies with a Saleae or similar? |
|
Well, with a scope, but yes, it's been checked. I haven't tried varying the
bus speed, but will do that with the next patch.
Given that this won't make 5.0 please leave the pr open for now while I
hunt down this bug.
…On Thu, 27 Feb 2020, 18:29 Dan Halbert, ***@***.***> wrote:
@mubes <https://github.com/mubes> Did you check the frequencies with a
Saleae or similar?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2659?email_source=notifications&email_token=ABJTBD2PVF67I7UQB2T3YETRFAA7PA5CNFSM4K44I46KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENFNWHI#issuecomment-592108317>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJTBD6EJ3XVTVGMYO2OQMDRFAA7PANCNFSM4K44I46A>
.
|
|
the underlying bug has now been found in the SDK and patches submitted. This one is now OK to merge. The checks failed when Github was unwell yesterday but I have no idea how to resubmit a checkjob. |
|
I restarted the jobs. I am not sure if you have access to the "Re-run jobs" button, but here's where it is: (edit: on the other hand, it says it's re-running them, but nothing is happening. I'll wait and see. Usually it works, but maybe GitHub is having problems.) |
|
Not looking good...a one line change and the world of circuitpython comes crashing down. Not even my code is that bad! |
|
Merging anyway, since some i.MX builds succeeded. Attempts to restart the actions failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take clock divider from the hardware rather than a define at the head of the code. Reduces i2c bitrate for 400kbps from around 2Mbps :-)