Skip to content

board_vina_m0:pins.c: PGM_LED is on PA28 not PA15. #2739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2020
Merged

board_vina_m0:pins.c: PGM_LED is on PA28 not PA15. #2739

merged 1 commit into from
Mar 30, 2020

Conversation

bd34n
Copy link

@bd34n bd34n commented Mar 30, 2020

PGM_LED is on PA28, not PA15.

@bd34n
Copy link
Author

bd34n commented Mar 30, 2020

Looks like there are some pre-commit check setup errors. A lot of errors like this:

Err:1 http://azure.archive.ubuntu.com/ubuntu xenial/main amd64 libunistring0 amd64 0.9.3-5.2ubuntu1
44
Could not connect to azure.archive.ubuntu.com:80 (52.177.174.250), connection timed out
45

Also looks like some other pull request pre-commit checks are failing with the same or similar reason. Hopefully transient?

@bd34n
Copy link
Author

bd34n commented Mar 30, 2020

Need advice - what is the proper way to proceed on this failure? Should I perform a dummy commit to have the check restarted? I believe the failure was not related to the code push itself, but rather in setting up the environment to run the pre-commit checks given the failure to connect to azure servers to download packages and similar.

Thanks!
-Brian

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An empty commit is fine. We're having CI issues so the retry I tried to manually do failed anyways. For this, I'll just merge. It looks fine. Thanks!

@tannewt tannewt merged commit 7bfc8b4 into adafruit:master Mar 30, 2020
@bd34n
Copy link
Author

bd34n commented Mar 30, 2020

Thank you, @tannewt!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants