Skip to content

mimxrt10xx: Fix neopixel_write #2740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2020
Merged

mimxrt10xx: Fix neopixel_write #2740

merged 1 commit into from
Mar 31, 2020

Conversation

arturo182
Copy link
Collaborator

Looks like the timing issues were caused by the code being in flash, moving it to ITCM and making sure no flash functions are called in the timing-critical section fixed the issue :)

Closes #2476

@arturo182 arturo182 added the mimxrt10xx iMX RT based boards such as Teensy 4.x label Mar 30, 2020
@arturo182 arturo182 requested a review from tannewt March 30, 2020 23:06
tannewt
tannewt approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

We'll be able to use SysTick shortly for this too once I swap time keeping to the RTC.

@tannewt tannewt merged commit e8cffcf into adafruit:master Mar 31, 2020
@arturo182 arturo182 deleted the mimxrt10xx_neopixel branch March 31, 2020 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
mimxrt10xx iMX RT based boards such as Teensy 4.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mimxrt10xx: Verify and possibly fix neopixel_write
2 participants
@arturo182 @tannewt