fix calculation of nrf firmware size #2800
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@xobs thanks for informal review in #2789 (comment).
CIRCUITPY_FIRMWARE_SIZE
needs to be calculated based on the start address of the region just above it.circuitpython/ports/nrf/boards/common.template.ld
Lines 8 to 18 in 51dbe91
The original calculation before #2789 is wrong because it didn't account for
FLASH_BLE_CONFIG
andFLASH_NVM
, but the #2789 change didn't account for the size ofFLASH_NVM
.