Standardize on FLASH_FIRMWARE section name in linker scripts #2817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for compatibility with the build_memory_info script
This change was scripted:
git grep -l FLASH_TEXT | xargs sed -i s/FLASH_TEXT/FLASH_FIRMWARE/
for compatibility with the build_memory_info script
This change was scripted:
git grep -l FLASH_TEXT | xargs sed -i s/FLASH_TEXT/FLASH_FIRMWARE/
for compatibility with the build_memory_info script
This led to incorrect results about free memory in the stm and i.mx ports
hierophect
requested changes
Apr 27, 2020
dhalbert
previously approved these changes
Apr 27, 2020
There was a problem hiding this comment.
This OK as is, but fine if you address @hierophect 's style requests and I will re-review.
With "git show -b" you can verify that this is a whitespace only change because the diff will be empty.
.. intead of just free and total as before.
dhalbert
requested changes
Apr 27, 2020
ports/litex/boards/fomu/fomu-spi.ld
Outdated
Comment on lines
10
to
12
| FLASH (rx) : ORIGIN = 0x20040000, LENGTH = 0x100000 /* entire flash, 1 MiB */ | ||
| FLASH_FIRMWARE (rx) : ORIGIN = 0x20040000, LENGTH = 0x100000 /* entire flash, 1 MiB */ | ||
| RAM (xrw) : ORIGIN = 0x10000000, LENGTH = 0x00020000 /* 128 KiB */ |
There was a problem hiding this comment.
Line up these but otherwise looks great.
With "git show -b" you can verify that this is a whitespace only change because the diff will be empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2816
This ended up touching stm, i.mx, and litex ports.
I only built, I didn't test on HW.