Skip to content

Digital In Out Type Hints #2913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 17, 2020
Merged

Digital In Out Type Hints #2913

merged 3 commits into from
May 17, 2020

Conversation

polkapolka
Copy link

Added type hints to DigitatlInOut.C file

@tannewt tannewt self-requested a review May 16, 2020 19:52
tannewt
tannewt requested changes May 16, 2020
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion but looks good otherwise! Thank you!

@polkapolka
Copy link
Author

Hey, so it's ready for another look

tannewt
tannewt approved these changes May 16, 2020
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll merge once the CI is happy.

@jepler jepler merged commit e518221 into adafruit:master May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@polkapolka @tannewt @jepler @ppolk-nocimed