Skip to content

Set up basic integration with pre-commit. #2981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 3, 2020
Merged

Conversation

Flameeyes
Copy link

This currently only checks for basic file hygiene, namely end-of-file and training whitespace.

This does not yet allow running REUSE, as there's a lot of files without
copyright information that need to be updated.

@Flameeyes Flameeyes force-pushed the master branch 6 times, most recently from b0087da to a2509a3 Compare May 30, 2020 10:14
@tannewt
Copy link
Member

tannewt commented Jun 1, 2020

Does the whitespace change leave one blank line at the end of the file? I think we tend to.

Looks like some test outputs were changed and broken. They'll need to be exempted.

@Flameeyes
Copy link
Author

Does the whitespace change leave one blank line at the end of the file? I think we tend to.

It leaves an empty line the way Emacs and other editors do — which matches what the Adafruit_CircuitPython_* libraries appear to have. It seems to be different in this repo though, and a lot of files have two empty lines, which is what it's correcting.

Looks like some test outputs were changed and broken. They'll need to be exempted.

Yeah I'm still trying to get this all to pass, it's not quite obvious for some of these tests which files need to be ignored. Sorry about that :(

Flameeyes added 2 commits June 3, 2020 10:56
This can be enforced by pre-commit, but correct it separately to make it easier to review.
@Flameeyes
Copy link
Author

Yay, passed!

I'll follow up with REUSE changes separately, since the CI is a bit heavy, and I don't have as much time as I had a couple of weeks ago, but I do have something working on.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, great! Thank you!

@tannewt tannewt merged commit 547beb5 into adafruit:master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants