Update cpboard.py #3005
Merged
Update cpboard.py #3005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theacodes
approved these changes
Jun 4, 2020
jepler
reviewed
Jun 4, 2020
tools/cpboard.py
Outdated
| def execute(self, code, timeout=10, async=False): | ||
| def execute(self, code, timeout=10, wait_for_response=False): |
There was a problem hiding this comment.
Hmmm I merged this PR and then I went looking at it. Isn't the sense of "wait_for_response" backwards from what it actually does?
There was a problem hiding this comment.
Isn't the sense of "wait_for_response" backwards from what it actually does?
Right you are. 🤦 I've actually had a few of these edits in branches as my use of it progressed; I think I had it proper at one point, but this definitely isn't. Fix imminent.
sommersoft
added a commit
to sommersoft/circuitpython
that referenced
this pull request
Jun 4, 2020
sommersoft
added a commit
that referenced
this pull request
Jun 6, 2020
Fix Backwards Logic of 'wait_for_response' In #3005
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty low-key PR. These are some changes I've been holding onto while working on RosiePi.
Biggest change is to the use of
asyncas a parameter/variable.asyncbecame a keyword in CPython 3.7, so its usage would raise an exception.Updated usage of
pyserialto match the changes from version 3.Ran
blackon the file.Added VID/PID for
itsybitsy_m4_expressto the respective USB device lookup functions