Skip to content

mimxrt10xx: fix issues with resets on the 1060 boards #3015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2020
Merged

mimxrt10xx: fix issues with resets on the 1060 boards #3015

merged 1 commit into from
Jun 5, 2020

Conversation

hierophect
Copy link
Collaborator

This PR fixes a very old typo in the pin definitions of the 1060 that lead to incorrect enums for a subset of pins used for flash memory. This was causing these pins to never be protected from reset, causing the chip to cut off its own flash memory.

Also fixes an issue for the Teensy pin definitions that skipped the protections for a critical pin, as it is grounded in the schematic, but which still needs to retain its pullup and drive settings across resets.

Properly solves #2998 - 1060 boards now have normal reset capability.

@hierophect hierophect added the mimxrt10xx iMX RT based boards such as Teensy 4.x label Jun 5, 2020
@hierophect hierophect requested a review from arturo182 June 5, 2020 20:52
Copy link
Collaborator

@arturo182 arturo182 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@arturo182 arturo182 merged commit 3cf96a5 into adafruit:master Jun 5, 2020
@hierophect hierophect deleted the mimxrt-1060-reset branch June 9, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mimxrt10xx iMX RT based boards such as Teensy 4.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants