More type hints #3193
Merged
More type hints #3193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciscorn
force-pushed
the
type-annotations
branch
4 times, most recently
from
8b81bff to
a8fdc19
Compare
ciscorn
force-pushed
the
type-annotations
branch
from
a8fdc19 to
54a342a
Compare
tannewt
requested changes
Jul 24, 2020
| @@ -10,30 +10,20 @@ | |||
| //| def __init__(self) -> None: | |||
| //| """Enum-like class to define the satellite system type.""" | |||
| //| | |||
| //| GPS: SatelliteSystem = ... | |||
| //| """Global Positioning System. | |||
| //| GPS: SatelliteSystem | |||
There was a problem hiding this comment.
It's valid with = ..., but:
- typeshed doesn’t use
= …for constants and data attributes. - sphinx-autoapi renders
= ...as '= Ellipsis' that can be confusing.
So I think just removing them is reasonable.
There was a problem hiding this comment.
Totally agree! Is there anyway we could check that the = ... isn't added?
ciscorn
force-pushed
the
type-annotations
branch
8 times, most recently
from
b8851a7 to
0822e67
Compare
ciscorn
force-pushed
the
type-annotations
branch
from
0822e67 to
d356581
Compare
|
@ciscorn Let us know when you're ready for review. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added and corrected some type annotations.
I also tweaked extract_pyi.py a bit.