Skip to content

adjust stack for SAMD21 to accommodate larger pystack #3213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 28, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
#define BOARD_USER_SAFE_MODE_ACTION "pressing both buttons at start up"

// Increase stack size slightly due to CPX library import nesting
#define CIRCUITPY_DEFAULT_STACK_SIZE (4760) //divisible by 8
#define CIRCUITPY_DEFAULT_STACK_SIZE (4248) //divisible by 8

#define USER_NEOPIXELS_PIN (&pin_PB23)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
#define BOARD_USER_SAFE_MODE_ACTION "pressing both buttons at start up"

// Increase stack size slightly due to CPX library import nesting
#define CIRCUITPY_DEFAULT_STACK_SIZE (4760) // divisible by 8
#define CIRCUITPY_DEFAULT_STACK_SIZE (4248) // divisible by 8

#define DEFAULT_I2C_BUS_SCL (&pin_PB03)
#define DEFAULT_I2C_BUS_SDA (&pin_PB02)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
#define BOARD_USER_SAFE_MODE_ACTION "pressing both buttons at start up"

// Increase stack size slightly due to CPX library import nesting.
#define CIRCUITPY_DEFAULT_STACK_SIZE (4760) // divisible by 8
#define CIRCUITPY_DEFAULT_STACK_SIZE (4248) // divisible by 8

#define USER_NEOPIXELS_PIN (&pin_PB23)

Expand Down
2 changes: 1 addition & 1 deletion ports/atmel-samd/mpconfigport.h
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@
#endif

#ifndef CIRCUITPY_DEFAULT_STACK_SIZE
#define CIRCUITPY_DEFAULT_STACK_SIZE 4096
#define CIRCUITPY_DEFAULT_STACK_SIZE 3584
#endif

#ifndef SAMD21_BOD33_LEVEL
Expand Down
2 changes: 1 addition & 1 deletion py/circuitpy_mpconfig.h
Original file line number Diff line number Diff line change
Expand Up @@ -799,7 +799,7 @@ void supervisor_run_background_tasks_if_tick(void);
#endif

#ifndef CIRCUITPY_PYSTACK_SIZE
#define CIRCUITPY_PYSTACK_SIZE 1024
#define CIRCUITPY_PYSTACK_SIZE 1536
#endif

#define CIRCUITPY_BOOT_OUTPUT_FILE "/boot_out.txt"
Expand Down