storage.erase_filesystem(): disconnect from USB and wait 1 second before resetting #3223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks Dan for tagging, that is good read. Disconnect and reconnect is a common way to go around this. Note on some MCUs the tud_disconnect() is not supported in the usb controller (may need external GPIO) but those are pretty old mcu design. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
storage.erase_filesystem()can cause an intermittent but frequent Linux crash. I considered this a Linux bug but have been informed that Linux doesn't see the need to guard against USB MSC devices acting badly.This change disconnects from USB before reformatting the filesystem and then waits for 1 second before resetting. This appears to prevent the Linux crashes: I tested multiple times.
My original Ubuntu bug report:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1871143
Correspondence on the linux-usb mailing list:
https://marc.info/?l=linux-usb&m=159387610928589&w=2
@hathach This may be of interest to you.