Skip to content

Add Bastwifi by Electronic Cats #3238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 28, 2020
Merged

Conversation

sabas1080
Copy link

@sabas1080 sabas1080 commented Aug 2, 2020

Hi Circuit Python Team

We have added our new board Bast WiFi with ESP32S2 https://electroniccats.com/store/bast-wifi/

Thanks

@sabas1080 sabas1080 requested a review from tannewt August 2, 2020 06:33
@sabas1080 sabas1080 requested a review from jepler August 3, 2020 00:54
@jepler
Copy link

jepler commented Aug 3, 2020

This should be good to merge after pidcodes/pidcodes.github.com#542 makes the PID allocation official.

@jepler
Copy link

jepler commented Aug 7, 2020

@tannewt pidcodes seems very slow to act, no github activity since April. I had suggested waiting for them to act, but should we just merge this anyway?

@jepler
Copy link

jepler commented Aug 10, 2020

@tannewt giving you some fresh mention-spam

@tannewt
Copy link
Member

tannewt commented Aug 10, 2020

Ok, I've pinged the pid.codes person to see if they need help doing reviews for the repo. (I'd be happy to help review.)

@dhalbert
Copy link
Collaborator

Letting this hang until pidcodes approves seems like a mistake, given that pidcodes has gone dormant. Since it's in a PR to pidcodes, and presumably no one else has asked for the same PID (maybe double-check) in another PR, I think we could go ahead and approve. Sound ok to you, @tannewt?

@dhalbert dhalbert merged commit ac06202 into adafruit:main Aug 28, 2020
@dhalbert
Copy link
Collaborator

Merged this for now; if necessary we can change the VID/PID later.

@dhalbert
Copy link
Collaborator

This broke in the build: https://github.com/adafruit/circuitpython/runs/1042094212?check_suite_focus=true. Maybe it's due to ESP-IDF changes?? I will revert this out for now.

@sabas1080 could you take a look?

@tannewt
Copy link
Member

tannewt commented Aug 28, 2020

Note that the build breakage wasn't caused by this PR. It is flakiness in the ESP build.

Fine with me to merge too.

@sabas1080
Copy link
Author

Thanks @tannewt @dhalbert

@sabas1080 sabas1080 deleted the bastwifi branch September 9, 2021 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants