-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add Bastwifi by Electronic Cats #3238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This should be good to merge after pidcodes/pidcodes.github.com#542 makes the PID allocation official. |
@tannewt pidcodes seems very slow to act, no github activity since April. I had suggested waiting for them to act, but should we just merge this anyway? |
@tannewt giving you some fresh mention-spam |
Ok, I've pinged the pid.codes person to see if they need help doing reviews for the repo. (I'd be happy to help review.) |
Letting this hang until pidcodes approves seems like a mistake, given that pidcodes has gone dormant. Since it's in a PR to pidcodes, and presumably no one else has asked for the same PID (maybe double-check) in another PR, I think we could go ahead and approve. Sound ok to you, @tannewt? |
Merged this for now; if necessary we can change the VID/PID later. |
This broke in the build: https://github.com/adafruit/circuitpython/runs/1042094212?check_suite_focus=true. Maybe it's due to ESP-IDF changes?? I will revert this out for now. @sabas1080 could you take a look? |
Note that the build breakage wasn't caused by this PR. It is flakiness in the ESP build. Fine with me to merge too. |
Hi Circuit Python Team
We have added our new board Bast WiFi with ESP32S2 https://electroniccats.com/store/bast-wifi/
Thanks