Skip to content

Issue3247 - Compiler optimization level causing displayio instability #3249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Issue3247 - Compiler optimization level causing displayio instability #3249

wants to merge 4 commits into from

Conversation

DavePutz
Copy link
Collaborator

@DavePutz DavePutz commented Aug 5, 2020

Testing the demo spirit level script for the Clue showed that with the -O2 optimization from PR #3190 the display was not stable. This PR reverts the optimization back to -Os.

DavePutz added 4 commits July 24, 2020 23:00
Issue#3247  Apparently using -O2 optimization on the Clue creates instability in displayio
@dhalbert
Copy link
Collaborator

dhalbert commented Aug 5, 2020

Testing the demo spirit level script for the Clue showed that with the -O2 optimization from PR #3190 the display was not stable. This PR reverts the optimization back to -Os.

In the past this kind of behavior (usually -Og vs -Os) has typically meant that something that should be volatile is not, or that there's some uninitialized.

@DavePutz
Copy link
Collaborator Author

DavePutz commented Aug 5, 2020

@dhalbert Are there any tools to help track that sort of thing down? I think safest for now is to take the relatively small performance hit and revert the optimization.

@dhalbert
Copy link
Collaborator

dhalbert commented Aug 5, 2020

We have no such tools now. Could you file a bug re displayio and optimization level? Thanks! I think we should assume this is a bug, not a compiler problem.

@deshipu
Copy link

deshipu commented Aug 6, 2020

I wonder if you could run valgrind on the unix build?

@DavePutz
Copy link
Collaborator Author

Closing, fixed by PR #3281. Tested OK with a Clue and Circuitplayground Bluefruit with an attached Gizmo display.

@DavePutz DavePutz closed this Aug 15, 2020
@dhalbert
Copy link
Collaborator

Great, thank you for testing!

@DavePutz DavePutz deleted the Issue3247 branch December 30, 2020 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants