-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Make pixelbuf support iterables and floats #3260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One memory question and looks good otherwise. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a merge to update things. Ok to merge after CI is happy.
@tannewt CI is happy. |
Unfortunately there's a full flash: |
I'll re-run this to see if the latest merge is better. This is a bit mysterious because the board is quite similar to other M0 Express boards. |
Metro M0 Express JA fits by only 36 bytes. The vina has a few extra pins. That explains it. |
The ja translation was not fitting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All builds fine now.
No description provided.