Added board - microS2 #3322
Merged
Added board - microS2 #3322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
previously requested changes
Aug 25, 2020
dhalbert
requested changes
Aug 26, 2020
|
The build was failing due to some trailing whitespace in a few files. I edited most of them in github, but making the @microdev1 If you can set your editor to automatically delete trailing whitespace on save, that will prevent these kinds of minor issues. Some editors have a setting, and some have a plugin to do this. |
|
@dhalbert Just added PSRAM support to sdkconfig |
|
Hi, you need to pull my changes from your repo, since your push put back the trailing whitespace. |
dhalbert
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added board specific config files for esp32s2 based microS2.