Skip to content

Fix for #3266: ensure SPI lock is free after a soft reboot #3378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Sep 11, 2020
Merged

Fix for #3266: ensure SPI lock is free after a soft reboot #3378

merged 13 commits into from
Sep 11, 2020

Conversation

DavePutz
Copy link
Collaborator

@DavePutz DavePutz commented Sep 7, 2020

Issue #3266. A change for to make sure that the SPI lock is free after a soft reboot.

@tannewt tannewt self-requested a review September 8, 2020 21:46
tannewt
tannewt requested changes Sep 8, 2020
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question about when SPI is used for a display. (Maybe this is the issue that causes the display to stop updating.)

@hierophect hierophect changed the title Issue #3266 Ensure SPI lock is free after a soft reboot Sep 9, 2020
@hierophect hierophect changed the title Ensure SPI lock is free after a soft reboot Fix for #3266: ensure SPI lock is free after a soft reboot Sep 9, 2020
tannewt
tannewt requested changes Sep 10, 2020
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the switch Dave! I think we'll want it in a bit different spot.

tannewt
tannewt approved these changes Sep 11, 2020
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit 01daf5b into adafruit:main Sep 11, 2020
@tannewt tannewt mentioned this pull request Sep 16, 2020
Closed
@tannewt tannewt mentioned this pull request Oct 21, 2020
Closed
@DavePutz DavePutz deleted the issue3266 branch December 30, 2020 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DavePutz @tannewt @siehputz