Skip to content

Add partition layouts for 8 and 16 MB as well. #3426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2020
Merged

Add partition layouts for 8 and 16 MB as well. #3426

merged 1 commit into from
Sep 17, 2020

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Sep 16, 2020

@UnexpectedMaker, please test your board with this change. My UM feather S2 isn't coming up with the bootloader.

@tannewt tannewt added enhancement espressif applies to multiple Espressif chips labels Sep 16, 2020
@tannewt tannewt added this to the 6.x.0 - Features milestone Sep 16, 2020
@tannewt tannewt requested a review from hathach September 16, 2020 01:18
@microdev1
Copy link
Collaborator

@tannewt Tested this on microS2 with 16MB flash, works like a charm.

cpy_drive

Thanks for adding. 👍

@tannewt tannewt requested a review from dhalbert September 16, 2020 15:53
dhalbert
dhalbert approved these changes Sep 17, 2020
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, though I don't have a a way to test it.

@tannewt tannewt merged commit 7f60ebd into adafruit:main Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

@hathach hathach Awaiting requested review from hathach

Assignees
No one assigned
Labels
enhancement espressif applies to multiple Espressif chips
Projects
None yet
Milestone
6.x.0 - Features
Development

Successfully merging this pull request may close these issues.
3 participants
@tannewt @microdev1 @dhalbert