ESP32-S2: AnalogOut #3514
Merged
ESP32-S2: AnalogOut #3514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update this now that the IDF switch is merged. |
tannewt
requested changes
Oct 8, 2020
|
@tannewt thanks for spotting that... how did it get in there? Git merge plays games with me that I'll never understand. |
|
Please merge in main so the diff here doesn't include the AnalogIn changes. |
|
@tannewt done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the AnalogOut module to the ESP32S2. Tested on a Saola 1 Wrover, works correctly across the ESP32S2's effective range of 0.1V minimum to 3.15V maximum.
Requires #3501 for merge compatibility. View latest commit for AnalogOut specific changes.