Skip to content

build.yml: Fix building mpy-cross-mac #3578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Conversation

jepler
Copy link

@jepler jepler commented Oct 20, 2020

Recently, the macos-10.15 image was updated with a non-brew version of awscli. This made our CI script, which does a brew install awscli fail:

Error: The `brew link` step did not complete successfully
The formula built, but is not symlinked into /usr/local
Could not symlink bin/aws
Target /usr/local/bin/aws
already exists. You may want to remove it:
  rm '/usr/local/bin/aws'

tannewt
tannewt previously approved these changes Oct 20, 2020
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this on 6.0.x? I think we generally want fixes there and then we can merge 6.0.x into main.

@jepler jepler changed the base branch from main to 6.0.x October 20, 2020 18:24
@jepler jepler dismissed tannewt’s stale review October 20, 2020 18:24

The base branch was changed.

Recently, the macos-10.15 image was updated with a non-brew version of awscli.  This made our CI script, which does a `brew install awscli` fail:
```
Error: The `brew link` step did not complete successfully
The formula built, but is not symlinked into /usr/local
Could not symlink bin/aws
Target /usr/local/bin/aws
already exists. You may want to remove it:
  rm '/usr/local/bin/aws'
```
@jepler jepler requested a review from tannewt October 20, 2020 18:25
@jepler
Copy link
Author

jepler commented Oct 21, 2020

@tannewt I updated this PR so it requests a merge into 6.0.x. There were build failures uploading artifacts, but the particular step we are interested in succeeded: https://github.com/adafruit/circuitpython/pull/3578/checks?check_run_id=1282721896

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit 1921143 into adafruit:6.0.x Oct 21, 2020
@jepler jepler deleted the fix-mac-actions branch November 3, 2021 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants